Add setHint/getHint to PhutilLockException for recent lock changes
ClosedPublic
Actions

Authored by epriestley on Oct 1 2018, 5:16 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13202: Plans: 2018 Week 38-40 Bonus Content

Commits

rPHUeca2a4b0321f: (stable) Promote 2018 Week 39
rARC9d6661002797: (Arcanist wilds) Add setHint/getHint to PhutilLockException for recent lock…
rPHUa0b90a12cee9: Add setHint/getHint to PhutilLockException for recent lock changes

Summary

Ref T13202. See PHI889. See D19702. A small part of that change affected libphutil, but got lost in the shuffle with all the Arcanist/wilds stuff in my local workspace.

Test Plan

See D19702.

Diff Detail

Repository

rPHU libphutil

Branch

lock1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20924
Build 28441: Run Core Tests
Build 28440: arc lint + arc unit

Event Timeline

epriestley created this revision.Oct 1 2018, 5:16 PM

Harbormaster completed remote builds in B20924: Diff 47115.Oct 1 2018, 5:16 PM

epriestley requested review of this revision.Oct 1 2018, 5:16 PM

amckinley accepted this revision.Oct 1 2018, 5:17 PM

This revision is now accepted and ready to land.Oct 1 2018, 5:17 PM

Closed by commit rPHUa0b90a12cee9: Add setHint/getHint to PhutilLockException for recent lock changes (authored by epriestley). · Explain WhyOct 1 2018, 5:28 PM

This revision was automatically updated to reflect the committed changes.

(I also "cherry-picked" this to wilds in Arcanist.)

epriestley mentioned this in T13109: Improve cluster write feedback and write routing.Oct 17 2018, 10:01 PM

Revision Contents
Changeset List

Path

Size

src/

filesystem/

PhutilLockException.php

15 lines

Diff 47115

View Options

src/filesystem/PhutilLockException.php

Add setHint/getHint to PhutilLockException for recent lock changesClosedPublicActions