Page MenuHomePhabricator

[Wilds] Rename "formatters" to "sinks" and restore the console output sufficiently to see which tests are failing
ClosedPublic

Authored by epriestley on Sep 26 2018, 4:07 PM.
Tags
None
Referenced Files
F13238323: D19711.id47125.diff
Tue, May 21, 6:45 PM
F13225540: D19711.diff
Sun, May 19, 3:42 PM
F13222543: D19711.diff
Sun, May 19, 3:45 AM
F13208119: D19711.id.diff
Thu, May 16, 9:29 AM
F13205220: D19711.diff
Wed, May 15, 1:35 AM
F13188725: D19711.diff
Sat, May 11, 5:26 AM
Unknown Object (File)
Tue, May 7, 9:08 AM
Unknown Object (File)
Fri, May 3, 8:48 AM
Subscribers
None

Details

Summary

Ref T13098. Since I plan to implement "send the results to Harbormaster" as another type of formatter/output/sink, just rename the objects which receive unit test results and print/write/transmit them into "Sinks" (in the sense of Source/Sink).

Get the default console sink working well enough to see what's failing. As with all other changes in this series this is very rough, but the general idea is that I want to:

  • Let sinks stream both ongoing status information and final results.
  • For the console output, try to increase the signal-to-noise ratio of the output stream. Today, it's too easy to lose a failed test in the results. I want to improve this by outputting less frequently and summarizing passes ("93 tests passed.") so that the streaming output mostly shows failures and it's easier to make a decision to ^C and revise if you see something you don't like.
  • Also, add a summary mode at the end which makes sure failures show up on the console and aren't scrolled up 30 pages. For now, this is quite rough.
Test Plan
373 PASSED * 16 SKIPPED * 162 FAILED/BROKEN/UNSTABLE

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 20908
Build 28423: Run Core Tests

Event Timeline

epriestley created this revision.
amckinley added inline comments.
src/unit/sink/ArcanistDefaultUnitSink.php
6

I slightly prefer SINK_KEY here. SINKKEY has kind of a nautical disaster flavor to it, don't you think?

This revision is now accepted and ready to land.Sep 26 2018, 9:35 PM
epriestley added inline comments.
src/unit/sink/ArcanistDefaultUnitSink.php
6

This is for consistentency with a lot of existing TYPECONST, EDGECONST, ENGINEKEY stuff, although I agree that SINKKEY reads pretty weirdly.

This revision was automatically updated to reflect the committed changes.