Page MenuHomePhabricator
Differential D19690

[Wilds] Allow "arc liberate" to liberate itself again
ClosedPublic
Actions

Authored by epriestley on Sep 18 2018, 7:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 24, 7:25 PM
Unknown Object (File)
Tue, Dec 24, 5:35 PM
Unknown Object (File)
Tue, Dec 24, 8:28 AM
Unknown Object (File)
Tue, Dec 17, 9:18 PM
Unknown Object (File)
Thu, Dec 12, 10:40 PM
Unknown Object (File)
Wed, Dec 11, 8:38 PM
Unknown Object (File)
Sat, Dec 7, 10:46 PM
Unknown Object (File)
Fri, Dec 6, 2:49 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13098: Plans: Arcanist toolsets and extensions
Commits
rARCc05bbd7be67a: [Wilds] Allow "arc liberate" to liberate itself again
Summary

Ref T13098. After libphutil/ and arcanist/ merged, some paths need to be adjusted. Try to organize things a little better, too.

Also, make arc liberate with no arguments just liberate all the libraries it can find.

Test Plan

Ran arc liberate and got a valid map rebuild, although I needed to apply some hacks on top of this to make the workflow reachable.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 20856
Build 28368: Run Core Tests

Event Timeline

epriestley requested review of this revision.Sep 18 2018, 7:58 PM
epriestley created this revision.
Harbormaster failed remote builds in B20856: Diff 47044!Sep 18 2018, 7:58 PM
amckinley accepted this revision.Sep 20 2018, 12:11 AM
This revision is now accepted and ready to land.Sep 20 2018, 12:11 AM
Closed by commit rARCc05bbd7be67a: [Wilds] Allow "arc liberate" to liberate itself again (authored by epriestley). · Explain WhySep 21 2018, 11:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
php/
scripts/
library/
library-map.php
phutil_rebuild_map.php
2 lines
library-symbols.php
phutil_symbols.php
6 lines
src/
moduleutils/
12 lines
workflow/
77 lines

Diff 47044

View Options

resources/php/php_compat_info.json

Loading...
View Options

resources/php_compat_info.json

Loading...
View Options

scripts/library/library-map.php

Loading...
View Options

scripts/library/library-symbols.php

Loading...
View Options

scripts/phutil_rebuild_map.php

Loading...
View Options

scripts/phutil_symbols.php

Loading...
View Options

src/moduleutils/PhutilLibraryMapBuilder.php

Loading...
View Options

src/workflow/ArcanistLiberateWorkflow.php

Loading...
Phabricator · Built by Phacility