Differential D19647

Continue replacing Commit/Audit status checks with object-based checks
ClosedPublic
Actions

Authored by epriestley on Sep 7 2018, 4:05 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13195: 2018 Week 36 Bonus Content

Commits

rPbae8a951143a: Continue replacing Commit/Audit status checks with object-based checks

Summary

Ref T13195. See PHI851. Continuing down the path toward replacing these legacy numeric constants with more modern string constants.

Test Plan

Raised concern, requested verification, verified.
Looked at commit hovercard with audit status.
Viewed header on a commit page.
(Didn't test the Doorkeeper stuff since it requires linking to Asana and seems unlikely to break.)

Diff Detail

Repository

rP Phabricator

Branch

audit5

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20761
Build 28230: Run Core Tests
Build 28229: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 7 2018, 4:05 PM

Harbormaster completed remote builds in B20761: Diff 46953.Sep 7 2018, 4:06 PM

epriestley requested review of this revision.Sep 7 2018, 4:06 PM

amckinley accepted this revision.Sep 10 2018, 4:15 PM

This revision is now accepted and ready to land.Sep 10 2018, 4:15 PM

Closed by commit rPbae8a951143a: Continue replacing Commit/Audit status checks with object-based checks (authored by epriestley). · Explain WhySep 10 2018, 6:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

constants/

PhabricatorAuditCommitStatusConstants.php

24 lines

editor/

PhabricatorAuditEditor.php

4 lines

diffusion/

controller/

DiffusionCommitController.php

13 lines

doorkeeper/

DiffusionDoorkeeperCommitFeedStoryPublisher.php

13 lines

engineextension/

DiffusionHovercardEngineExtension.php

10 lines

query/

DiffusionCommitRequiredActionResultBucket.php

11 lines

xaction/

DiffusionCommitConcernTransaction.php

4 lines

DiffusionCommitStateTransaction.php

39 lines

DiffusionCommitVerifyTransaction.php

3 lines

repository/

storage/

PhabricatorRepositoryCommit.php

20 lines

Diff 46953

View Options

src/applications/audit/constants/PhabricatorAuditCommitStatusConstants.php

View Options

src/applications/audit/editor/PhabricatorAuditEditor.php

View Options

src/applications/diffusion/controller/DiffusionCommitController.php

View Options

src/applications/diffusion/doorkeeper/DiffusionDoorkeeperCommitFeedStoryPublisher.php

View Options

src/applications/diffusion/engineextension/DiffusionHovercardEngineExtension.php

View Options

src/applications/diffusion/query/DiffusionCommitRequiredActionResultBucket.php

View Options

src/applications/diffusion/xaction/DiffusionCommitConcernTransaction.php

View Options

src/applications/diffusion/xaction/DiffusionCommitStateTransaction.php

View Options

src/applications/diffusion/xaction/DiffusionCommitVerifyTransaction.php

View Options

src/applications/repository/storage/PhabricatorRepositoryCommit.php

Continue replacing Commit/Audit status checks with object-based checksClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 46953

src/applications/audit/constants/PhabricatorAuditCommitStatusConstants.php

src/applications/audit/editor/PhabricatorAuditEditor.php

src/applications/diffusion/controller/DiffusionCommitController.php

src/applications/diffusion/doorkeeper/DiffusionDoorkeeperCommitFeedStoryPublisher.php

src/applications/diffusion/engineextension/DiffusionHovercardEngineExtension.php

src/applications/diffusion/query/DiffusionCommitRequiredActionResultBucket.php

src/applications/diffusion/xaction/DiffusionCommitConcernTransaction.php

src/applications/diffusion/xaction/DiffusionCommitStateTransaction.php

src/applications/diffusion/xaction/DiffusionCommitVerifyTransaction.php

src/applications/repository/storage/PhabricatorRepositoryCommit.php

Continue replacing Commit/Audit status checks with object-based checks
ClosedPublic
Actions

Revision Contents
Changeset List