Page MenuHomePhabricator

Begin transitioning audits to modern (string) status constants, from legacy (integer) status constants
ClosedPublic

Authored by epriestley on Sep 5 2018, 5:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 21, 3:01 PM
Unknown Object (File)
Thu, Jan 16, 9:01 AM
Unknown Object (File)
Fri, Jan 10, 6:59 PM
Unknown Object (File)
Sat, Jan 4, 8:40 PM
Unknown Object (File)
Wed, Jan 1, 6:52 PM
Unknown Object (File)
Wed, Dec 25, 10:54 AM
Unknown Object (File)
Dec 20 2024, 12:20 PM
Unknown Object (File)
Dec 19 2024, 6:03 PM
Subscribers
None

Details

Summary

Ref T13195. See PHI851. Audits currently have older integer status constants. We've moved almost all object types away from this to string constants (which are better in basically every way, and particularly way better for exposing over the API).

Commits/audits are currently accessible over the API and expose these constants via a "statuses" constraint.

Prepare to move toward modern string constants by defining a new, more modern map of status details and defining the existing methods in terms of it.

Test Plan

Browsed audits checking for icons/names/open-ness, saw no changes. This change should have no user-visible effects, as it just reorganizes code.

Diff Detail

Repository
rP Phabricator
Branch
auditoptions3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20744
Build 28207: Run Core Tests
Build 28206: arc lint + arc unit