Differential D19634

Allow reviewers to mark their own inlines as "Done" before they submit them
ClosedPublic
Actions

Authored by epriestley on Sep 4 2018, 7:02 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T8573: All reviewers should be allowed to mark a comment as done
T13195: 2018 Week 36 Bonus Content

Commits

rP16a6fc8341ea: Allow reviewers to mark their own inlines as "Done" before they submit them

Summary

Ref T13195. Ref T8573. This allows reviewers to mark their own inline comments as "Done" before they submit them.

If you're leaving a non-actionable comment like "this is good", you can pre-check "Done" to give the author a hint that you don't expect any response.

Test Plan

On revisions and commits, added inlines as the author and a reviewer/auditor. Marked them done/not-done before submitting. As author, marked the not-done ones done after submitting. Checked preivews, toggled done/not done states.

Diff Detail

Repository

rP Phabricator

Branch

selfinline2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20734
Build 28187: Run Core Tests
Build 28186: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 4 2018, 7:02 PM

Harbormaster completed remote builds in B20734: Diff 46926.Sep 4 2018, 7:03 PM

epriestley requested review of this revision.Sep 4 2018, 7:03 PM

epriestley mentioned this in T8573: All reviewers should be allowed to mark a comment as done.Sep 4 2018, 7:16 PM

amckinley accepted this revision.Sep 5 2018, 10:32 PM

amckinley added inline comments.

src/applications/diffusion/controller/DiffusionInlineCommentController.php
86–87	I read the discussion in T8573, but this still feels weird.

This revision is now accepted and ready to land.Sep 5 2018, 10:32 PM

epriestley added inline comments.Sep 6 2018, 3:07 PM

src/applications/diffusion/controller/DiffusionInlineCommentController.php
86–87	Hmm, which part feels weird? The motivation? The actual action? Would it still feel weird if the UI said "Don't bother the author with a done checkbox for this comment [X]"?