Page MenuHomePhabricator

Pass commit authorship information to Buildkite
ClosedPublic

Authored by epriestley on Aug 27 2018, 7:50 PM.
Tags
None
Referenced Files
F18292534: D19614.id46890.diff
Sat, Aug 23, 12:19 PM
F18110324: D19614.id46890.diff
Mon, Aug 11, 6:31 PM
F18049914: D19614.id.diff
Sun, Aug 3, 5:47 PM
F18010157: D19614.diff
Sat, Aug 2, 3:44 PM
F17711955: D19614.diff
Jul 17 2025, 9:20 AM
Unknown Object (File)
Jun 8 2025, 10:20 PM
Unknown Object (File)
May 31 2025, 3:52 PM
Unknown Object (File)
May 30 2025, 3:34 PM
Subscribers
Restricted Owners Package

Details

Summary

Fixes T12251. Ref T13189. See PHI610. The difficulty here is that we don't want to disclose Phabricator account information to Buildkite. We're comfortable disclosing information from git, etc.

  • For commits, use the Identity to provide authorship information from Git.
  • For revisions, use the local commit information on the Diff to provide the Git/Mercurial/etc author of the HEAD commit.
Test Plan
  • Built commits and revisions in Buildkite via Harbormaster.
  • I can't actually figure out how to see author information on the Buildkite side, but the values look sane when dumped locally.

Diff Detail

Repository
rP Phabricator
Branch
buildkite1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20694
Build 28127: Run Core Tests
Build 28126: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.Aug 27 2018, 7:50 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 27 2018, 7:51 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.