Extract needed classes/interfaces from return types
ClosedPublic
Actions

Authored by joshuaspence on Aug 15 2018, 2:07 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHUac350a7fe787: Extract needed classes/interfaces from return types

Summary

Improves scripts/phutil_symbols.php so as to support extracting needed symbols from function return types.

Test Plan

Ran script/phutil_symbols.php on the following file:

<?php

function x(array $x): void {}

function y(string $x): bool {}

The output was as follows:

{
  "have": {
    "function": {
      "x": 16,
      "y": 47
    }
  },
  "need": {
    "class/interface": {
      "string": 49,
      "void": 29,
      "bool": 61
    }
  },
  "xmap": []
}

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence created this revision.Aug 15 2018, 2:07 AM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 15 2018, 2:07 AM

Harbormaster completed remote builds in B20620: Diff 46821.Aug 15 2018, 2:07 AM

joshuaspence requested review of this revision.Aug 15 2018, 2:07 AM

Herald added a subscriber: Korvin. · View Herald TranscriptAug 15 2018, 2:07 AM

epriestley accepted this revision.Aug 15 2018, 4:59 PM

This revision is now accepted and ready to land.Aug 15 2018, 4:59 PM

Closed by commit rPHUac350a7fe787: Extract needed classes/interfaces from return types (authored by joshuaspence). · Explain WhyAug 15 2018, 8:43 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

scripts/

phutil_symbols.php

12 lines

Diff 46826

View Options

scripts/phutil_symbols.php

Extract needed classes/interfaces from return typesClosedPublicActions