When cancelling addition of an Almanac interface, return to the Device page
ClosedPublic
Actions

Authored by epriestley on Aug 13 2018, 4:32 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13184: "Add Interface" > "Cancel" in Almanac takes you nowhere, instead of back to the device

Commits

rPfb3ae72e367f: When cancelling addition of an Almanac interface, return to the Device page

Summary

Fixes T13184. In Almanac, interfaces are always added to devices. However, if you "Add New Interface" and then "Cancel", you go to the nonexistent /interface/ page.

Instead, return to the device page.

Test Plan

From a device page, clicked "Add Interface" and then "Cancel". Ended up back where I was.

Diff Detail

Repository

rP Phabricator

Branch

repops2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20596
Build 27980: Run Core Tests
Build 27979: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 13 2018, 4:32 PM

Harbormaster completed remote builds in B20596: Diff 46794.Aug 13 2018, 4:34 PM

epriestley requested review of this revision.Aug 13 2018, 4:34 PM

amckinley accepted this revision.Aug 13 2018, 6:20 PM

This revision is now accepted and ready to land.Aug 13 2018, 6:20 PM

Closed by commit rPfb3ae72e367f: When cancelling addition of an Almanac interface, return to the Device page (authored by epriestley). · Explain WhyAug 13 2018, 6:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

almanac/

editor/

AlmanacInterfaceEditEngine.php

3 lines

Diff 46794

View Options

src/applications/almanac/editor/AlmanacInterfaceEditEngine.php

When cancelling addition of an Almanac interface, return to the Device pageClosedPublicActions