Page MenuHomePhabricator

When building a config stack, stop SiteSource objects from poisoning the cache
ClosedPublic

Authored by epriestley on Jul 20 2018, 9:39 PM.
Tags
None
Referenced Files
F15401922: D19526.id.diff
Mon, Mar 17, 7:47 PM
F15392430: D19526.id46695.diff
Sat, Mar 15, 3:10 PM
F15331755: D19526.id46688.diff
Fri, Mar 7, 1:24 PM
Unknown Object (File)
Feb 9 2025, 6:11 AM
Unknown Object (File)
Feb 9 2025, 6:11 AM
Unknown Object (File)
Feb 9 2025, 6:10 AM
Unknown Object (File)
Feb 9 2025, 1:43 AM
Unknown Object (File)
Feb 7 2025, 10:59 AM
Subscribers
None

Details

Summary

Ref T13168. I'm not sure how this worked before, but I ran into this issue on my new laptop.

SiteSource accesses PhabrictatorEnv::getEnvConfig('phabricator.base-uri') when local, which may poison the cache and lock the value since we don't later discard the cache.

Specifically, when I access http://locala.phacility.com, I was getting an error like "You made a request for locala.phacility.com, but no configured site can serve this request.". This was because the base-uri was being incorrectly frozen as "local.phacility.com". The expectation is that it will match, so the standard PlatformSite will serve the request.

Test Plan
  • Before change: "no configured site" error.
  • After change: local instance works properly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable