Page MenuHomePhabricator

When building a config stack, stop SiteSource objects from poisoning the cache
ClosedPublic

Authored by epriestley on Jul 20 2018, 9:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 18, 7:22 AM
Unknown Object (File)
Fri, Dec 27, 8:13 PM
Unknown Object (File)
Dec 19 2024, 1:01 AM
Unknown Object (File)
Dec 6 2024, 12:01 AM
Unknown Object (File)
Nov 1 2024, 10:08 PM
Unknown Object (File)
Oct 30 2024, 9:14 AM
Unknown Object (File)
Oct 29 2024, 3:13 PM
Unknown Object (File)
Oct 18 2024, 1:02 AM
Subscribers
None

Details

Summary

Ref T13168. I'm not sure how this worked before, but I ran into this issue on my new laptop.

SiteSource accesses PhabrictatorEnv::getEnvConfig('phabricator.base-uri') when local, which may poison the cache and lock the value since we don't later discard the cache.

Specifically, when I access http://locala.phacility.com, I was getting an error like "You made a request for locala.phacility.com, but no configured site can serve this request.". This was because the base-uri was being incorrectly frozen as "local.phacility.com". The expectation is that it will match, so the standard PlatformSite will serve the request.

Test Plan
  • Before change: "no configured site" error.
  • After change: local instance works properly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable