Page MenuHomePhabricator

When building a config stack, stop SiteSource objects from poisoning the cache
ClosedPublic

Authored by epriestley on Jul 20 2018, 9:39 PM.
Tags
None
Referenced Files
F13176755: D19526.id46695.diff
Wed, May 8, 4:51 PM
Unknown Object (File)
Tue, May 7, 5:00 PM
Unknown Object (File)
Tue, May 7, 10:15 AM
Unknown Object (File)
Fri, May 3, 10:37 AM
Unknown Object (File)
Sat, Apr 27, 6:23 AM
Unknown Object (File)
Thu, Apr 25, 3:55 AM
Unknown Object (File)
Fri, Apr 19, 7:49 PM
Unknown Object (File)
Apr 1 2024, 7:20 AM
Subscribers
None

Details

Summary

Ref T13168. I'm not sure how this worked before, but I ran into this issue on my new laptop.

SiteSource accesses PhabrictatorEnv::getEnvConfig('phabricator.base-uri') when local, which may poison the cache and lock the value since we don't later discard the cache.

Specifically, when I access http://locala.phacility.com, I was getting an error like "You made a request for locala.phacility.com, but no configured site can serve this request.". This was because the base-uri was being incorrectly frozen as "local.phacility.com". The expectation is that it will match, so the standard PlatformSite will serve the request.

Test Plan
  • Before change: "no configured site" error.
  • After change: local instance works properly.

Diff Detail

Repository
rP Phabricator
Branch
ccache1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20486
Build 27824: Run Core Tests
Build 27823: arc lint + arc unit