Page MenuHomePhabricator

Improve Python HMAC example in webhook documentation
AbandonedPublic

Authored by fwilson42 on Jun 26 2018, 2:33 AM.
Tags
None
Referenced Files
F13191432: D19508.diff
Sat, May 11, 8:59 PM
F13177698: D19508.diff
Wed, May 8, 7:54 PM
Unknown Object (File)
Mon, Apr 29, 4:22 PM
Unknown Object (File)
Thu, Apr 25, 12:02 AM
Unknown Object (File)
Sun, Apr 21, 6:51 PM
Unknown Object (File)
Fri, Apr 19, 7:48 PM
Unknown Object (File)
Wed, Apr 17, 6:53 PM
Unknown Object (File)
Sun, Apr 14, 2:49 PM
Subscribers
Tokens
"Hungry Hippo" token, awarded by yelirekim.

Details

Summary

This changes the example from a "subprocess" call out to PHP to use
Python's standard library "hmac" instead. This removes the dependency
on PHP; webhooks might not be run on a machine with it installed.

Test Plan

Run the PHP example with key = "test key" and body = "test body":

echo hash_hmac('sha256', 'test body', 'test key');
// => e327344d7533dfd50ceed6541c3ba412b06cc52b0cdfc900fcaf58992b470617

Run the Python example with the same parameters (Python 2):

>>> import hashlib
>>> import hmac
>>> hmac.new('test key', 'test body', hashlib.sha256).hexdigest()
'e327344d7533dfd50ceed6541c3ba412b06cc52b0cdfc900fcaf58992b470617'

And Python 3:

>>> import hashlib
>>> import hmac
>>> hmac.new(b'test key', b'test body', hashlib.sha256).hexdigest()
'e327344d7533dfd50ceed6541c3ba412b06cc52b0cdfc900fcaf58992b470617'

Note that all values are the same.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20453
Build 27780: arc lint + arc unit