Page MenuHomePhabricator

Don't set mail HTML bodies if there's no actual HTML body
ClosedPublic

Authored by epriestley on Jun 15 2018, 7:06 PM.
Tags
None
Referenced Files
F15454836: D19494.diff
Sat, Mar 29, 8:44 PM
F15442073: D19494.diff
Wed, Mar 26, 9:11 PM
F15435837: D19494.id46618.diff
Tue, Mar 25, 10:30 AM
F15395536: D19494.diff
Sun, Mar 16, 7:48 AM
Unknown Object (File)
Mar 2 2025, 2:28 AM
Unknown Object (File)
Feb 9 2025, 6:08 AM
Unknown Object (File)
Feb 9 2025, 6:08 AM
Unknown Object (File)
Feb 9 2025, 6:08 AM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/commit-6011085b0fcd-breaks-sending-certain-email/1571. Some mailers get upset if we setHTMLBody(...) with an empty string.

There's some possible argument they should be more graceful about this, but it's reasonably pretty ambiguous.

Only try to set the HTML body if we actually have a nonempty HTML body.

Test Plan
  • Configured an "smtp" mailer.
  • Ran echo hi | ./bin/mail send-test --to someone@somewhere.com --subject test.
  • Before: error about empty message body.
  • After: no more message body error.

Diff Detail

Repository
rP Phabricator
Branch
html1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20423
Build 27736: Run Core Tests
Build 27735: arc lint + arc unit