Page MenuHomePhabricator

Fix an issue where entering the same Owners path for two repositories would incorrectly de-dupe the path
ClosedPublic

Authored by epriestley on May 1 2018, 1:58 PM.
Tags
None
Referenced Files
F19825187: D19420.id.diff
Sun, Mar 8, 8:29 AM
F19816931: D19420.id.diff
Thu, Mar 5, 9:29 AM
F19809331: D19420.id46456.diff
Tue, Mar 3, 8:55 AM
F19791869: D19420.diff
Thu, Feb 26, 12:29 AM
F19790595: D19420.diff
Wed, Feb 25, 9:42 PM
F19696438: D19420.id46456.diff
Tue, Feb 10, 2:20 PM
F19664832: D19420.diff
Feb 7 2026, 12:27 PM
F19104883: D19420.diff
Dec 5 2025, 3:44 PM
Subscribers
None

Details

Summary

Ref T13130. See https://discourse.phabricator-community.org/t/unable-to-create-owners-package-with-same-path-in-multiple-repositories/1400/1.

When you edit paths in Owners, we deduplicate similar paths, like /x/y and /x/y/. However, this logic currently only examines the paths, and incorrectly deduplicates the same path in different repositories.

Instead, consider the repository before deduplicating.

Test Plan
  • Edited an Owners package and added the path "/" in two different repositories.
  • Before: only one surived the edit.
  • After: both survived.

Diff Detail

Repository
rP Phabricator
Branch
owners1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20267
Build 27510: Run Core Tests
Build 27509: arc lint + arc unit