Differential D19413

Add a "Rule Detail" link to Herald email
ClosedPublic
Actions

Authored by epriestley on Apr 28 2018, 1:14 PM.

Tags

None

Referenced Files

	F15428598: D19413.id46438.diff
	Sun, Mar 23, 9:16 PM

	F15413361: D19413.diff
	Wed, Mar 19, 6:16 PM

	Unknown Object (File)
	Feb 20 2025, 9:52 PM

	Unknown Object (File)
	Feb 20 2025, 9:52 PM

	Unknown Object (File)
	Feb 20 2025, 9:52 PM

	Unknown Object (File)
	Feb 20 2025, 9:52 PM

	Unknown Object (File)
	Feb 17 2025, 4:04 AM

	Unknown Object (File)
	Feb 9 2025, 6:00 AM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Maniphest Tasks

T13130: Plans: 2018 Week 17/18 Bonus Content

Commits

rPef48a2b2eebc: Add a "Rule Detail" link to Herald email

Summary

See PHI285. Ref T13130. After recent changes Herald sends email about rules, but the mail doesn't currently actually include a link to the rule.

Include a link for consistency and ease-of-use.

Test Plan

Edited a rule, looked at the resulting mail, saw a link to the rule.

Diff Detail

Repository

rP Phabricator

Branch

herald1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20249
Build 27484: Run Core Tests
Build 27483: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 28 2018, 1:14 PM

Harbormaster completed remote builds in B20249: Diff 46438.Apr 28 2018, 1:15 PM

epriestley requested review of this revision.Apr 28 2018, 1:15 PM

amckinley accepted this revision.Apr 30 2018, 12:47 AM

This revision is now accepted and ready to land.Apr 30 2018, 12:47 AM

Closed by commit rPef48a2b2eebc: Add a "Rule Detail" link to Herald email (authored by epriestley). · Explain WhyApr 30 2018, 12:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

editor/

HeraldRuleEditor.php

14 lines

storage/

HeraldRule.php

4 lines

Diff 46438

View Options

src/applications/herald/editor/HeraldRuleEditor.php