Paths

Table of Contentst

Differential D19393

Fix odd line number line wrapping on embedded pastes (`{Pxxx}`)
ClosedPublic
Actions

Authored by epriestley on Apr 20 2018, 8:16 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13126: Plans: Diffusion cleanup for document engine

Commits

rP33da9f833fdd: Fix odd line number line wrapping on embedded pastes (`{Pxxx}`)

Summary

Ref T13126. After SourceView changes, embedded pastes with the {Pxxx} syntax are line-wrapping line numbers in Safari, at least. Put a stop to this.

Test Plan

Viewed a {Pxxx} with more than 10 lines. Before: weird line wrapping; after: nice consistent display.

Diff Detail

Repository

rP Phabricator

Branch

paste1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20200
Build 27413: Run Core Tests
Build 27412: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 20 2018, 8:16 PM

Harbormaster completed remote builds in B20200: Diff 46387.Apr 20 2018, 8:17 PM

epriestley requested review of this revision.Apr 20 2018, 8:17 PM

amckinley accepted this revision.Apr 20 2018, 9:06 PM

This revision is now accepted and ready to land.Apr 20 2018, 9:06 PM

Closed by commit rP33da9f833fdd: Fix odd line number line wrapping on embedded pastes (`{Pxxx}`) (authored by epriestley). · Explain WhyApr 20 2018, 9:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

4 lines

webroot/

rsrc/

css/

layout/

phabricator-source-code-view.css

1 line

Diff 46387

View Options

resources/celerity/map.php