Paths

Table of Contentst

Differential D19371

Add an "--auto" flag to "bin/differential migrate-hunk"
ClosedPublic
Actions

Authored by epriestley on Apr 16 2018, 1:45 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Dec 21, 4:38 PM

	Unknown Object (File)
	Thu, Dec 12, 5:39 AM

	Unknown Object (File)
	Wed, Dec 11, 8:42 PM

	Unknown Object (File)
	Sun, Dec 8, 10:41 AM

	Unknown Object (File)
	Wed, Dec 4, 8:47 AM

	Unknown Object (File)
	Sat, Nov 30, 2:07 PM

	Unknown Object (File)
	Tue, Nov 26, 8:49 AM

	Unknown Object (File)
	Nov 22 2024, 5:24 PM

Subscribers

None

Details

Reviewers

Commits

rPb5f23b023e3c: Add an "--auto" flag to "bin/differential migrate-hunk"

Summary

Depends on D19370. See T13124. See PHI549. The particular install in PHI549 migrated a large amount of data via the fallback hunk migration script, which does not compress hunks.

Add a mode to bin/differential migrate-hunk that amounts to "compress all the hunks which would benefit from compression".

Test Plan

Ran bin/differential migrate-hunk with --auto, --all, --to, --id, and --dry-run in various mixtures. Forced a bunch of hunks to raw ("byte") format, saw it cleanly upgrade them to compressed ("gzde") format.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 16 2018, 1:45 PM

Harbormaster completed remote builds in B20153: Diff 46336.Apr 16 2018, 1:46 PM

epriestley requested review of this revision.Apr 16 2018, 1:46 PM

amckinley accepted this revision.Apr 16 2018, 5:12 PM

This revision is now accepted and ready to land.Apr 16 2018, 5:12 PM

Closed by commit rPb5f23b023e3c: Add an "--auto" flag to "bin/differential migrate-hunk" (authored by epriestley). · Explain WhyApr 16 2018, 7:27 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

management/

PhabricatorDifferentialMigrateHunkWorkflow.php

116 lines

storage/

DifferentialHunk.php

22 lines

Diff 46345

src/applications/differential/management/PhabricatorDifferentialMigrateHunkWorkflow.php

Loading...

src/applications/differential/storage/DifferentialHunk.php

Loading...