Fix argument ordering in error message
ClosedPublic
Actions

Authored by amckinley on Apr 10 2018, 5:01 PM.

Details

Reviewers

epriestley

Commits

rPd398bcd67c76: Fix argument ordering in error message

Summary

Before:

$ ./config set phabricator.base-uri local.phacility.com:8080
Usage Exception: Config option 'http://' is invalid. The URI must start with https://' or 'phabricator.base-uri'.

After:

$ ./config set phabricator.base-uri local.phacility.com:8080
Usage Exception: Config option 'phabricator.base-uri' is invalid. The URI must start with http://' or 'https://'.

Test Plan

See above

Diff Detail

Repository

rP Phabricator

Branch

uri-typo

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20064
Build 27216: Run Core Tests
Build 27215: arc lint + arc unit

Event Timeline

amckinley created this revision.Apr 10 2018, 5:01 PM

Harbormaster completed remote builds in B20061: Diff 46237.Apr 10 2018, 5:02 PM

amckinley requested review of this revision.Apr 10 2018, 5:02 PM

Herald added a subscriber: Korvin. · View Herald TranscriptApr 10 2018, 5:02 PM

epriestley accepted this revision.Apr 10 2018, 5:06 PM

epriestley added inline comments.

src/applications/config/option/PhabricatorCoreConfigOptions.php
271–273	Missing single quote here, too, I think, before the first `%s`. (Consider rewriting so that the values are double-quoted for consistency -- I've been gradually trying to move our strings so that "values" are more consistently enclosed in "double quotes".)