Paths

Table of Contentst

Differential D19319

Fix the wrapping/padding behavior of Remarkup code block headers more thoroughly?
ClosedPublic
Actions

Authored by epriestley on Apr 9 2018, 11:34 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13118: Code block headers wrap in the dumbest way in Safari

Commits

rP4c4a5a7656e1: Fix the wrapping/padding behavior of Remarkup code block headers more…

Summary

Ref T13118. The first fix there fixed Safari, but made Chrome weird. Try this?

Test Plan

Viewed a code block with name=... in Safari, Firefox and Chrome and saw consistent display without weird wrappping.

Diff Detail

Repository

rP Phabricator

Branch

codehead1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20048
Build 27189: Run Core Tests
Build 27188: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 9 2018, 11:34 PM

Harbormaster completed remote builds in B20048: Diff 46224.Apr 9 2018, 11:35 PM

epriestley requested review of this revision.Apr 9 2018, 11:35 PM

amckinley accepted this revision.Apr 9 2018, 11:36 PM

This revision is now accepted and ready to land.Apr 9 2018, 11:36 PM

Closed by commit rP4c4a5a7656e1: Fix the wrapping/padding behavior of Remarkup code block headers more… (authored by epriestley). · Explain WhyApr 10 2018, 11:37 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

core/

remarkup.css

2 lines

Diff 46224

View Options

resources/celerity/map.php