Page MenuHomePhabricator

Pull file Document Engine rendering out of "Files" application controllers
ClosedPublic

Authored by epriestley on Apr 5 2018, 4:17 PM.
Tags
None
Referenced Files
F13149832: D19301.id.diff
Sat, May 4, 11:41 AM
Unknown Object (File)
Fri, May 3, 3:42 AM
Unknown Object (File)
Mon, Apr 29, 6:04 PM
Unknown Object (File)
Mon, Apr 29, 6:04 PM
Unknown Object (File)
Mon, Apr 29, 6:04 PM
Unknown Object (File)
Mon, Apr 29, 3:44 PM
Unknown Object (File)
Sat, Apr 27, 1:07 PM
Unknown Object (File)
Thu, Apr 25, 6:36 PM
Subscribers
None

Details

Summary

Ref T13105. This separates document rendering from the Controllers which trigger it so it can be reused elsewhere (notably, in Diffusion).

This shouldn't cause any application behavior to change, it just pulls the rendering logic out so it can be reused elsewhere.

Test Plan

Viewed various types of files in Files; toggled rendering, highlighting, and encoding.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable