Page MenuHomePhabricator

Pull file Document Engine rendering out of "Files" application controllers
ClosedPublic

Authored by epriestley on Apr 5 2018, 4:17 PM.
Tags
None
Referenced Files
F13096727: D19301.diff
Thu, Apr 25, 6:36 PM
Unknown Object (File)
Wed, Apr 24, 11:43 PM
Unknown Object (File)
Sat, Apr 20, 4:39 PM
Unknown Object (File)
Sat, Apr 20, 10:23 AM
Unknown Object (File)
Fri, Apr 19, 7:38 PM
Unknown Object (File)
Sun, Apr 14, 9:47 AM
Unknown Object (File)
Thu, Apr 11, 8:00 AM
Unknown Object (File)
Sun, Apr 7, 3:10 PM
Subscribers
None

Details

Summary

Ref T13105. This separates document rendering from the Controllers which trigger it so it can be reused elsewhere (notably, in Diffusion).

This shouldn't cause any application behavior to change, it just pulls the rendering logic out so it can be reused elsewhere.

Test Plan

Viewed various types of files in Files; toggled rendering, highlighting, and encoding.

Diff Detail

Repository
rP Phabricator
Branch
dfile2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20011
Build 27134: Run Core Tests
Build 27133: arc lint + arc unit