Page MenuHomePhabricator

Make closed/disabled results in the remarkup autocomplete more visually clear
ClosedPublic

Authored by epriestley on Mar 30 2018, 3:45 PM.
Tags
None
Referenced Files
F14121250: D19272.diff
Fri, Nov 29, 11:55 AM
Unknown Object (File)
Tue, Nov 26, 12:47 AM
Unknown Object (File)
Thu, Nov 21, 5:05 AM
Unknown Object (File)
Tue, Nov 12, 8:28 PM
Unknown Object (File)
Sat, Nov 9, 3:05 PM
Unknown Object (File)
Mon, Nov 4, 12:23 AM
Unknown Object (File)
Oct 22 2024, 6:47 AM
Unknown Object (File)
Oct 5 2024, 5:46 AM
Subscribers
None

Details

Summary

Ref T13114. See PHI522. Although it looks like results are already ordered correctly, the override rendering isn't accommodating disabled results gracefully.

Give closed results a distinctive look (grey + strikethru) so it's clear when you're autocompleting @mention... into a disabled user.

Test Plan

Screen Shot 2018-03-30 at 8.41.49 AM.png (221×362 px, 23 KB)

Diff Detail

Repository
rP Phabricator
Branch
disable1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19952
Build 27048: Run Core Tests
Build 27047: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 30 2018, 3:46 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.