Page MenuHomePhabricator

Make closed/disabled results in the remarkup autocomplete more visually clear
ClosedPublic

Authored by epriestley on Mar 30 2018, 3:45 PM.
Tags
None
Referenced Files
F13137422: D19272.diff
Thu, May 2, 6:52 PM
Unknown Object (File)
Thu, Apr 25, 2:11 AM
Unknown Object (File)
Fri, Apr 19, 7:37 PM
Unknown Object (File)
Wed, Apr 17, 2:54 PM
Unknown Object (File)
Mar 31 2024, 11:27 AM
Unknown Object (File)
Mar 21 2024, 11:22 PM
Unknown Object (File)
Jan 29 2024, 4:45 PM
Unknown Object (File)
Jan 25 2024, 1:00 AM
Subscribers
None

Details

Summary

Ref T13114. See PHI522. Although it looks like results are already ordered correctly, the override rendering isn't accommodating disabled results gracefully.

Give closed results a distinctive look (grey + strikethru) so it's clear when you're autocompleting @mention... into a disabled user.

Test Plan

Screen Shot 2018-03-30 at 8.41.49 AM.png (221×362 px, 23 KB)

Diff Detail

Repository
rP Phabricator
Branch
disable1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19952
Build 27048: Run Core Tests
Build 27047: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 30 2018, 3:46 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.