Page MenuHomePhabricator

Make closed/disabled results in the remarkup autocomplete more visually clear
ClosedPublic

Authored by epriestley on Mar 30 2018, 3:45 PM.
Tags
None
Referenced Files
F17699333: D19272.id46133.diff
Tue, Jul 15, 7:55 PM
F17698785: D19272.id46131.diff
Tue, Jul 15, 7:27 PM
F17673744: D19272.diff
Sun, Jul 13, 5:32 AM
Unknown Object (File)
Jun 17 2025, 6:09 AM
Unknown Object (File)
May 19 2025, 8:01 PM
Unknown Object (File)
May 6 2025, 12:25 PM
Unknown Object (File)
May 6 2025, 1:56 AM
Unknown Object (File)
Apr 25 2025, 10:00 AM
Subscribers
None

Details

Summary

Ref T13114. See PHI522. Although it looks like results are already ordered correctly, the override rendering isn't accommodating disabled results gracefully.

Give closed results a distinctive look (grey + strikethru) so it's clear when you're autocompleting @mention... into a disabled user.

Test Plan

Screen Shot 2018-03-30 at 8.41.49 AM.png (221×362 px, 23 KB)

Diff Detail

Repository
rP Phabricator
Branch
disable1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19952
Build 27048: Run Core Tests
Build 27047: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 30 2018, 3:46 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.