Page MenuHomePhabricator
Differential D19272

Make closed/disabled results in the remarkup autocomplete more visually clear
ClosedPublic
Actions

Authored by epriestley on Mar 30 2018, 3:45 PM.
Tags
None
Referenced Files
F15471192: D19272.diff
Sat, Apr 5, 4:04 AM
F15447306: D19272.diff
Thu, Mar 27, 11:02 PM
F15431670: D19272.id.diff
Mon, Mar 24, 1:51 PM
F15425716: D19272.id46133.diff
Sun, Mar 23, 5:39 AM
F15424831: D19272.diff
Sun, Mar 23, 12:24 AM
F15417346: D19272.diff
Thu, Mar 20, 4:42 PM
F15415851: D19272.id46131.diff
Thu, Mar 20, 7:59 AM
F15377279: D19272.diff
Mar 13 2025, 8:31 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13114: Plans: 2018 Week 13 Bonus Content
Commits
rP7eaa27683e97: Make closed/disabled results in the remarkup autocomplete more visually clear
Summary

Ref T13114. See PHI522. Although it looks like results are already ordered correctly, the override rendering isn't accommodating disabled results gracefully.

Give closed results a distinctive look (grey + strikethru) so it's clear when you're autocompleting @mention... into a disabled user.

Test Plan

Screen Shot 2018-03-30 at 8.41.49 AM.png (221×362 px, 23 KB)

Diff Detail

Repository
rP Phabricator
Branch
disable1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19952
Build 27048: Run Core Tests
Build 27047: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 30 2018, 3:45 PM
Harbormaster completed remote builds in B19952: Diff 46131.Mar 30 2018, 3:46 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 30 2018, 3:46 PM
epriestley requested review of this revision.
Closed by commit rP7eaa27683e97: Make closed/disabled results in the remarkup autocomplete more visually clear (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
22 lines
webroot/
rsrc/
css/
core/
5 lines
js/
phuix/
5 lines

Diff 46131

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/core/remarkup.css

Loading...
View Options

webroot/rsrc/js/phuix/PHUIXAutocomplete.js

Loading...
Phabricator · Built by Phacility