Page MenuHomePhabricator
Differential D19270

Provide comment actions for tokenizer custom fields
ClosedPublic
Actions

Authored by epriestley on Mar 29 2018, 9:06 PM.
Tags
None
Referenced Files
F15492466: D19270.diff
Sat, Apr 12, 2:45 PM
F15469876: D19270.diff
Fri, Apr 4, 5:39 PM
F15459434: D19270.id.diff
Mon, Mar 31, 12:56 PM
F15459363: D19270.id46129.diff
Mon, Mar 31, 12:21 PM
F15453212: D19270.id46128.diff
Sat, Mar 29, 10:10 AM
F15444502: D19270.id.diff
Thu, Mar 27, 9:50 AM
F15442049: D19270.diff
Wed, Mar 26, 9:06 PM
F15439412: D19270.id46129.diff
Wed, Mar 26, 7:24 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13114: Plans: 2018 Week 13 Bonus Content
Commits
rP9fbf4ee58c0d: Provide comment actions for tokenizer custom fields
Summary

Ref T13114. See PHI519. An install is interested in modifying a tokenizer custom field from the comment area. Provide this capability.

This patch is fairly narrow but should solve the immediate need.

Test Plan

Added, removed, and modified a tokenizer custom field using the comment action dropdown.

Diff Detail

Repository
rP Phabricator
Branch
custom1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/infrastructure/customfield/editor/PhabricatorCustomFieldEditField.php:96XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 19949
Build 27043: Run Core Tests
Build 27042: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 29 2018, 9:06 PM
Harbormaster completed remote builds in B19949: Diff 46128.Mar 29 2018, 9:07 PM
epriestley requested review of this revision.Mar 29 2018, 9:07 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 29 2018, 9:10 PM
Closed by commit rP9fbf4ee58c0d: Provide comment actions for tokenizer custom fields (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
infrastructure/
customfield/
editor/
34 lines
field/
21 lines
standard/
22 lines

Diff 46128

View Options

src/infrastructure/customfield/editor/PhabricatorCustomFieldEditField.php

Loading...
View Options

src/infrastructure/customfield/field/PhabricatorCustomField.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldTokenizer.php

Loading...
Phabricator · Built by Phacility