Page MenuHomePhabricator
Differential D19270

Provide comment actions for tokenizer custom fields
ClosedPublic
Actions

Authored by epriestley on Mar 29 2018, 9:06 PM.
Tags
None
Referenced Files
F18791889: D19270.id.diff
Thu, Oct 16, 6:33 PM
F18741133: D19270.id.diff
Thu, Oct 2, 8:47 AM
F18739732: D19270.diff
Wed, Oct 1, 10:41 PM
F18617078: D19270.diff
Sep 14 2025, 8:09 PM
F18596617: D19270.id46128.diff
Sep 13 2025, 1:06 AM
F18509486: D19270.id.diff
Sep 5 2025, 3:26 AM
F18502510: D19270.diff
Sep 4 2025, 10:29 PM
F18434145: D19270.id.diff
Aug 31 2025, 8:57 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13114: Plans: 2018 Week 13 Bonus Content
Commits
rP9fbf4ee58c0d: Provide comment actions for tokenizer custom fields
Summary

Ref T13114. See PHI519. An install is interested in modifying a tokenizer custom field from the comment area. Provide this capability.

This patch is fairly narrow but should solve the immediate need.

Test Plan

Added, removed, and modified a tokenizer custom field using the comment action dropdown.

Diff Detail

Repository
rP Phabricator
Branch
custom1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/infrastructure/customfield/editor/PhabricatorCustomFieldEditField.php:96XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 19949
Build 27043: Run Core Tests
Build 27042: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 29 2018, 9:06 PM
Harbormaster completed remote builds in B19949: Diff 46128.Mar 29 2018, 9:07 PM
epriestley requested review of this revision.Mar 29 2018, 9:07 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 29 2018, 9:10 PM
Closed by commit rP9fbf4ee58c0d: Provide comment actions for tokenizer custom fields (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
infrastructure/
customfield/
editor/
34 lines
field/
21 lines
standard/
22 lines

Diff 46128

View Options

src/infrastructure/customfield/editor/PhabricatorCustomFieldEditField.php

Loading...
View Options

src/infrastructure/customfield/field/PhabricatorCustomField.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldTokenizer.php

Loading...
Phabricator · Built by Phacility