Page MenuHomePhabricator

Render object monograms and embedding references more gracefully when building a Remarkup table of contents
ClosedPublic

Authored by epriestley on Mar 16 2018, 10:37 PM.
Tags
None
Referenced Files
F13208170: D19234.diff
Thu, May 16, 10:37 AM
Unknown Object (File)
Wed, May 1, 12:39 AM
Unknown Object (File)
Apr 19 2024, 7:33 PM
Unknown Object (File)
Apr 11 2024, 10:31 AM
Unknown Object (File)
Apr 7 2024, 6:45 PM
Unknown Object (File)
Mar 31 2024, 11:23 AM
Unknown Object (File)
Mar 17 2024, 6:33 AM
Unknown Object (File)
Mar 10 2024, 7:53 AM
Subscribers
None

Details

Summary

Fixes T8845. Ref T13102. See PHI467. Currently, object monograms like L1 which appear in Remarkup headers render incorrectly (with an internal placeholder "x") in the table of contents:

Screen Shot 2018-03-16 at 3.31.55 PM.png (347×372 px, 21 KB)

Instead, render them down to just, e.g., L1 in plain text.

For {P123} I just rendered it to {P123} since it's not really clear to me what users intend. This could be adjusted if there's some reasonable thing that someone is trying to do with this.

Test Plan

Wrote a Phriction document with several object references (like L1 and {P123}) in headers. After patch, saw "x"-free, sensible-looking header names in the table of contents.

Diff Detail

Repository
rP Phabricator
Branch
remarkup1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19872
Build 26931: Run Core Tests
Build 26930: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 16 2018, 10:44 PM
This revision was automatically updated to reflect the committed changes.