Page MenuHomePhabricator
Differential D19231

Clarify that a PHUITagView API argument is boolean, not a value in "millimeters"
ClosedPublic
Actions

Authored by epriestley on Mar 16 2018, 8:08 PM.
Tags
None
Referenced Files
F13277076: D19231.diff
Fri, May 31, 8:22 AM
F13265900: D19231.diff
Tue, May 28, 7:06 AM
F13246001: D19231.diff
Thu, May 23, 7:07 AM
F13244307: D19231.id46048.diff
Thu, May 23, 4:41 AM
F13219221: D19231.diff
Sat, May 18, 4:31 PM
F13218459: D19231.id.diff
Sat, May 18, 12:36 PM
F13200580: D19231.diff
Tue, May 14, 1:45 AM
F13185249: D19231.id.diff
Sat, May 11, 2:43 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13102: Plans: 2018 Week 11 Bonus Content
Commits
rP667955b8aeca: Clarify that a PHUITagView API argument is boolean, not a value in "millimeters"
Summary

See PHI454. Ref T13102. This parameter is not named as clearly as it could be.

This is a buff to API humor.

See also https://secure.phabricator.com/differential/diff/46024/.

Test Plan

Read API method, laughed aloud ("LAL") much harder because the humor was now less subtle. Subtle humor is unsuitable for this project.

Diff Detail

Repository
rP Phabricator
Branch
humor1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19865
Build 26921: Run Core Tests
Build 26920: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 16 2018, 8:08 PM
Harbormaster completed remote builds in B19865: Diff 46048.Mar 16 2018, 8:09 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 16 2018, 8:09 PM
epriestley requested review of this revision.
Closed by commit rP667955b8aeca: Clarify that a PHUITagView API argument is boolean, not a value in "millimeters" (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
view/
phui/
4 lines

Diff 46048

View Options

src/view/phui/PHUITagView.php

Loading...
Phabricator · Built by Phacility