Differential D19231

Clarify that a PHUITagView API argument is boolean, not a value in "millimeters"
ClosedPublic
Actions

Authored by epriestley on Mar 16 2018, 8:08 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 20, 8:32 AM

	Unknown Object (File)
	Sat, Nov 16, 12:42 PM

	Unknown Object (File)
	Wed, Nov 13, 7:41 PM

	Unknown Object (File)
	Tue, Nov 12, 6:50 AM

	Unknown Object (File)
	Mon, Nov 11, 5:09 PM

	Unknown Object (File)
	Fri, Nov 8, 1:02 PM

	Unknown Object (File)
	Tue, Nov 5, 9:34 PM

	Unknown Object (File)
	Tue, Nov 5, 10:41 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13102: Plans: 2018 Week 11 Bonus Content
Commits: rP667955b8aeca: Clarify that a PHUITagView API argument is boolean, not a value in "millimeters"

Summary

See PHI454. Ref T13102. This parameter is not named as clearly as it could be.

This is a buff to API humor.

Test Plan

Read API method, laughed aloud ("LAL") much harder because the humor was now less subtle. Subtle humor is unsuitable for this project.

Diff Detail

Repository

rP Phabricator

Branch

humor1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19865
Build 26921: Run Core Tests
Build 26920: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 16 2018, 8:08 PM

Harbormaster completed remote builds in B19865: Diff 46048.Mar 16 2018, 8:09 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 16 2018, 8:09 PM

epriestley requested review of this revision.

Closed by commit rP667955b8aeca: Clarify that a PHUITagView API argument is boolean, not a value in "millimeters" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

view/

phui/

PHUITagView.php

4 lines

Diff 46048

View Options

src/view/phui/PHUITagView.php

Clarify that a PHUITagView API argument is boolean, not a value in "millimeters"ClosedPublicActions