Allow projects to be queried by slug in "project.search"
ClosedPublic
Actions

Authored by epriestley on Mar 16 2018, 7:56 PM.

Details

Reviewers: None
Maniphest Tasks: T13102: Plans: 2018 Week 11 Bonus Content
Commits: rPc216fd40728b: Allow projects to be queried by slug in "project.search"

Summary

Ref T13102. See PHI461. An install is interested in querying projects by slug.

I think I omitted this capability originally only because we're not consistent about what slugs are called (they are "Slugs" internally, but "Hashtags" in the UI).

However, this ship has sort of already sailed because the results have a "slug" field. Just expose this as "slugs" for consistency with the existing API field and try to smooth thing over with a little documentation hint.

Test Plan

Queried for projects by slug, got the desired results back.

Diff Detail

Repository

rP Phabricator

Branch

slug1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19864
Build 26919: Run Core Tests
Build 26918: arc lint + arc unit

Event Timeline

Re-diff with a clean version of arc that doesn't add the commit message as a synthetic changeset.

Harbormaster completed remote builds in B19863: Diff 46046.Mar 16 2018, 7:57 PM

Harbormaster completed remote builds in B19864: Diff 46047.

epriestley requested review of this revision.Mar 16 2018, 7:58 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 16 2018, 8:08 PM

Closed by commit rPc216fd40728b: Allow projects to be queried by slug in "project.search" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

query/

PhabricatorProjectSearchEngine.php

12 lines

Diff 46047

View Options

src/applications/project/query/PhabricatorProjectSearchEngine.php

Allow projects to be queried by slug in "project.search"ClosedPublicActions