Page MenuHomePhabricator
Differential D19212

Allow PhutilSortVector to self-sort
ClosedPublic
Actions

Authored by epriestley on Mar 13 2018, 2:00 PM.
Tags
None
Referenced Files
F18206216: D19212.id46008.diff
Mon, Aug 18, 3:35 PM
F18204479: D19212.diff
Mon, Aug 18, 1:47 PM
F18050758: D19212.id46008.diff
Sun, Aug 3, 8:58 PM
F18008960: D19212.id.diff
Sat, Aug 2, 2:50 PM
F17958617: D19212.diff
Fri, Aug 1, 7:10 AM
Unknown Object (File)
Jun 15 2025, 1:29 PM
Unknown Object (File)
May 31 2025, 12:13 PM
Unknown Object (File)
May 29 2025, 12:44 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13103: Document favicon customization and validate the "ui.favicons" configuration option
Commits
rPHUa3e02f01c34f: Allow PhutilSortVector to self-sort
Summary

Ref T13103 . msortv() requires a list which can be mpull()'d, so it's hard to use in an ad-hoc way. Allow a list of Vectors to sort itself.

Test Plan

See D19209.

Diff Detail

Repository
rPHU libphutil
Branch
sort1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19825
Build 26861: Run Core Tests
Build 26860: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 13 2018, 2:00 PM
Harbormaster completed remote builds in B19825: Diff 46007.Mar 13 2018, 2:01 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 13 2018, 2:01 PM
epriestley requested review of this revision.
Closed by commit rPHUa3e02f01c34f: Allow PhutilSortVector to self-sort (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley edited the summary of this revision. (Show Details)Mar 13 2018, 4:30 PM
epriestley added a task: T13103: Document favicon customization and validate the "ui.favicons" configuration option.

Revision Contents
Changeset List

PathSize
src/
utils/
7 lines

Diff 46007

View Options

src/utils/PhutilSortVector.php

Loading...
Phabricator · Built by Phacility