Paths

Table of Contentst

Differential D19212

Allow PhutilSortVector to self-sort
ClosedPublic
Actions

Authored by epriestley on Mar 13 2018, 2:00 PM.

Tags

None

Referenced Files

	F13163221: D19212.diff
	Mon, May 6, 6:32 PM

	Unknown Object (File)
	Thu, Apr 25, 12:55 AM

	Unknown Object (File)
	Fri, Apr 19, 7:33 PM

	Unknown Object (File)
	Fri, Apr 19, 4:18 AM

	Unknown Object (File)
	Thu, Apr 18, 8:15 PM

	Unknown Object (File)
	Wed, Apr 17, 5:33 PM

	Unknown Object (File)
	Thu, Apr 11, 9:49 PM

	Unknown Object (File)
	Thu, Apr 11, 5:52 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13103: Document favicon customization and validate the "ui.favicons" configuration option
Commits: rPHUa3e02f01c34f: Allow PhutilSortVector to self-sort

Summary

Ref T13103 . msortv() requires a list which can be mpull()'d, so it's hard to use in an ad-hoc way. Allow a list of Vectors to sort itself.

Test Plan

See D19209.

Diff Detail

Repository

rPHU libphutil

Branch

sort1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19825
Build 26861: Run Core Tests
Build 26860: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 13 2018, 2:00 PM

Harbormaster completed remote builds in B19825: Diff 46007.Mar 13 2018, 2:01 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 13 2018, 2:01 PM

epriestley requested review of this revision.

Closed by commit rPHUa3e02f01c34f: Allow PhutilSortVector to self-sort (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley edited the summary of this revision. (Show Details)Mar 13 2018, 4:30 PM

epriestley added a task: T13103: Document favicon customization and validate the "ui.favicons" configuration option.

Revision Contents
Changeset List

Path

Size

src/

utils/

PhutilSortVector.php

7 lines

Diff 46007

View Options

src/utils/PhutilSortVector.php

Allow PhutilSortVector to self-sortClosedPublicActions