Differential D19205

Fix missing parameter in parent call for Differential button text
ClosedPublic
Actions

Authored by epriestley on Mar 9 2018, 1:20 PM.

Tags

None

Referenced Files

	F13264597: D19205.diff
	Mon, May 27, 7:11 PM

	F13246756: D19205.diff
	Thu, May 23, 1:43 PM

	F13214272: D19205.id45992.diff
	Fri, May 17, 9:39 AM

	F13198031: D19205.diff
	Mon, May 13, 2:57 AM

	F13180229: D19205.diff
	Wed, May 8, 10:40 PM

	Unknown Object (File)
	Wed, May 1, 5:46 PM

	Unknown Object (File)
	Apr 13 2024, 5:10 PM

	Unknown Object (File)
	Apr 2 2024, 7:38 PM

View All Files

Subscribers

None

Details

Reviewers: None
Commits: rP1763b516b158: Fix missing parameter in parent call for Differential button text

Summary

See https://discourse.phabricator-community.org/t/openning-any-differential-fails-with-undefined-variable-object/1216/1.

Test Plan

Loaded any non-draft revision.

Diff Detail

Repository

rP Phabricator

Branch

draft2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19808
Build 26837: Run Core Tests
Build 26836: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 9 2018, 1:20 PM

Harbormaster completed remote builds in B19808: Diff 45992.Mar 9 2018, 1:21 PM

epriestley requested review of this revision.Mar 9 2018, 1:21 PM

epriestley mentioned this in D19204: Add some more UI reminder text about draft revisions.Mar 9 2018, 1:22 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 9 2018, 1:23 PM

Closed by commit rP1763b516b158: Fix missing parameter in parent call for Differential button text (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialRevisionEditEngine.php

2 lines

Diff 45992

View Options

src/applications/differential/editor/DifferentialRevisionEditEngine.php

Fix missing parameter in parent call for Differential button textClosedPublicActions