Page MenuHomePhabricator
Differential D19205

Fix missing parameter in parent call for Differential button text
ClosedPublic
Actions

Authored by epriestley on Mar 9 2018, 1:20 PM.
Tags
None
Referenced Files
F15456294: D19205.id45992.diff
Sun, Mar 30, 8:29 AM
F15448371: D19205.id45993.diff
Fri, Mar 28, 4:30 AM
F15447440: D19205.id.diff
Thu, Mar 27, 11:53 PM
F15440863: D19205.diff
Wed, Mar 26, 3:06 PM
F15431037: D19205.diff
Mon, Mar 24, 10:11 AM
F15416762: D19205.id45993.diff
Thu, Mar 20, 1:20 PM
F15414071: D19205.diff
Wed, Mar 19, 10:58 PM
F15413242: D19205.diff
Wed, Mar 19, 5:37 PM
View All Files
Subscribers
None

Details

Reviewers
None
Commits
rP1763b516b158: Fix missing parameter in parent call for Differential button text
Summary

See https://discourse.phabricator-community.org/t/openning-any-differential-fails-with-undefined-variable-object/1216/1.

Test Plan

Loaded any non-draft revision.

Diff Detail

Repository
rP Phabricator
Branch
draft2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19808
Build 26837: Run Core Tests
Build 26836: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 9 2018, 1:20 PM
Harbormaster completed remote builds in B19808: Diff 45992.Mar 9 2018, 1:21 PM
epriestley requested review of this revision.Mar 9 2018, 1:21 PM
epriestley mentioned this in D19204: Add some more UI reminder text about draft revisions.Mar 9 2018, 1:22 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 9 2018, 1:23 PM
Closed by commit rP1763b516b158: Fix missing parameter in parent call for Differential button text (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
editor/
2 lines

Diff 45992

View Options

src/applications/differential/editor/DifferentialRevisionEditEngine.php

Loading...
Phabricator · Built by Phacility