Page MenuHomePhabricator
Differential D19196

Always serve "{meme ...}" from the CDN domain, never from the primary domain
ClosedPublic
Actions

Authored by epriestley on Mar 8 2018, 3:40 PM.
Tags
None
Referenced Files
F14844153: D19196.id45976.diff
Sun, Feb 2, 1:37 PM
F14844148: D19196.id45975.diff
Sun, Feb 2, 1:34 PM
Unknown Object (File)
Wed, Jan 29, 3:43 AM
Unknown Object (File)
Tue, Jan 28, 8:02 AM
Unknown Object (File)
Tue, Jan 28, 3:33 AM
Unknown Object (File)
Tue, Jan 28, 1:22 AM
Unknown Object (File)
Mon, Jan 27, 9:22 AM
Unknown Object (File)
Sat, Jan 25, 10:39 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy
Commits
rP98cac2cc2994: Always serve "{meme ...}" from the CDN domain, never from the primary domain
Summary

Ref T13101. This is a minimal change to make "{meme ...}" work with the new Content-Security-Policy by using an Ajax request to generate the image and then swapping the source on the client.

This could be much cleaner (see T5258, etc).

Test Plan

Used {meme, src=cat6, above=i am, below=cat}, chuckled completely unironically.

Diff Detail

Repository
rP Phabricator
Branch
meme1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19792
Build 26813: Run Core Tests
Build 26812: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 8 2018, 3:40 PM
Harbormaster completed remote builds in B19792: Diff 45975.Mar 8 2018, 3:41 PM
epriestley requested review of this revision.Mar 8 2018, 3:41 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 8 2018, 3:47 PM
Closed by commit rP98cac2cc2994: Always serve "{meme ...}" from the CDN domain, never from the primary domain (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T13172: Saved meme-maker results are case-insensitive.Jul 20 2018, 10:26 PM

Revision Contents
Changeset List

PathSize
src/
applications/
macro/
controller/
120 lines
markup/
11 lines
infrastructure/
markup/
view/
12 lines

Diff 45975

View Options

src/applications/macro/controller/PhabricatorMacroMemeController.php

Loading...
View Options

src/applications/macro/markup/PhabricatorMemeRemarkupRule.php

Loading...
View Options

src/infrastructure/markup/view/PHUIRemarkupImageView.php

Loading...
Phabricator · Built by Phacility