Page MenuHomePhabricator

Separate the "{img ...}" remarkup rule into separate parse and markup phases
ClosedPublic

Authored by epriestley on Mar 8 2018, 1:03 PM.
Tags
None
Referenced Files
F15453906: D19192.id45971.diff
Sat, Mar 29, 2:59 PM
F15452438: D19192.id45966.diff
Sat, Mar 29, 4:51 AM
F15444895: D19192.id45967.diff
Thu, Mar 27, 11:45 AM
F15442470: D19192.id.diff
Wed, Mar 26, 11:38 PM
F15436567: D19192.diff
Tue, Mar 25, 3:15 PM
F15428378: D19192.id45967.diff
Sun, Mar 23, 7:59 PM
Unknown Object (File)
Feb 21 2025, 3:34 PM
Unknown Object (File)
Feb 18 2025, 9:01 AM
Subscribers
None

Details

Summary

Ref T13101. Ref T4190. This rule is currently single-phase but I'd like to check for a valid proxied image in cache already and just emit an <img ... /> tag pointing at it if we have one.

To support batching these lookups, split the rule into a parse phase (where we extract URIs) and a markup phase (where we build tags).

Test Plan

Used {img ...} in Remarkup with no apparent behavioral changes. (This change should do nothing on its own.)

Diff Detail

Repository
rP Phabricator
Branch
image1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19784
Build 26801: Run Core Tests
Build 26800: arc lint + arc unit

Event Timeline

epriestley created this revision.
  • Improve word use in comment.
This revision was not accepted when it landed; it landed in state Needs Review.Mar 8 2018, 3:03 PM
This revision was automatically updated to reflect the committed changes.