Separate the "{img ...}" remarkup rule into separate parse and markup phases
ClosedPublic
Actions

Authored by epriestley on Mar 8 2018, 1:03 PM.

Details

Reviewers: None
Maniphest Tasks: T4190: Rebuild remarkup image proxying
T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy
Commits: rP01bbd71b9683: Separate the "{img ...}" remarkup rule into separate parse and markup phases

Summary

Ref T13101. Ref T4190. This rule is currently single-phase but I'd like to check for a valid proxied image in cache already and just emit an <img ... /> tag pointing at it if we have one.

To support batching these lookups, split the rule into a parse phase (where we extract URIs) and a markup phase (where we build tags).

Test Plan

Used {img ...} in Remarkup with no apparent behavioral changes. (This change should do nothing on its own.)

Diff Detail

Repository

rP Phabricator

Branch

image1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19784
Build 26801: Run Core Tests
Build 26800: arc lint + arc unit

Event Timeline

Improve word use in comment.

Harbormaster completed remote builds in B19783: Diff 45966.Mar 8 2018, 1:04 PM

Harbormaster completed remote builds in B19784: Diff 45967.

epriestley requested review of this revision.Mar 8 2018, 1:05 PM

epriestley added a child revision: D19193: When proxying an "{image ...}" image fails, show the user an error message.Mar 8 2018, 1:36 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 8 2018, 3:03 PM

Closed by commit rP01bbd71b9683: Separate the "{img ...}" remarkup rule into separate parse and markup phases (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

files/

markup/

PhabricatorImageRemarkupRule.php

67 lines

Diff 45967

View Options

src/applications/files/markup/PhabricatorImageRemarkupRule.php

Separate the "{img ...}" remarkup rule into separate parse and markup phasesClosedPublicActions