Differential D19188

Restore lightbox behavior for thumbnailed images
ClosedPublic
Actions

Authored by epriestley on Mar 7 2018, 3:25 PM.

Details

Reviewers: None
Maniphest Tasks: T13099: Plans: 2018 Week 10 Bonus Content
Commits: rP05b9016fc385: (stable) Restore lightbox behavior for thumbnailed images
rP229d4677701a: Restore lightbox behavior for thumbnailed images

Summary

Ref T13099. See https://discourse.phabricator-community.org/t/lightbox-not-working/1201. The Content-Security-Policy changes rewrote some of this code and the handling for "Download" links is incorrectly catching clicks on thumbnailed images.

Test Plan

Clicked a thumbnailed image, got a lightbox. Command-clicked a download link, still got link behavior instead of a lightbox.

Diff Detail

Repository

rP Phabricator

Branch

lightbox1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19774
Build 26786: Run Core Tests
Build 26785: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 7 2018, 3:25 PM

Harbormaster failed remote builds in B19773: Diff 45957!Mar 7 2018, 3:26 PM

Update Celerity map.

Harbormaster completed remote builds in B19774: Diff 45958.Mar 7 2018, 3:29 PM

epriestley requested review of this revision.Mar 7 2018, 3:29 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 7 2018, 3:33 PM

Closed by commit rP229d4677701a: Restore lightbox behavior for thumbnailed images (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

24 lines

webroot/

rsrc/

js/

core/

behavior-lightbox-attachments.js

5 lines

Diff 45958

View Options

resources/celerity/map.php