Page MenuHomePhabricator
Files F15376378

D19188.diff
No OneTemporary
Actions

D19188.diff
View Options

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -10,7 +10,7 @@
'conpherence.pkg.css' => 'e68cf1fa',
'conpherence.pkg.js' => '15191c65',
'core.pkg.css' => '2fa91e14',
- 'core.pkg.js' => 'a3ceffdb',
+ 'core.pkg.js' => 'e4d73c62',
'darkconsole.pkg.js' => '1f9a31bc',
'differential.pkg.css' => '113e692c',
'differential.pkg.js' => 'f6d809c0',
@@ -494,7 +494,7 @@
'rsrc/js/core/behavior-hovercard.js' => 'bcaccd64',
'rsrc/js/core/behavior-keyboard-pager.js' => 'a8da01f0',
'rsrc/js/core/behavior-keyboard-shortcuts.js' => '01fca1f0',
- 'rsrc/js/core/behavior-lightbox-attachments.js' => 'e31fad01',
+ 'rsrc/js/core/behavior-lightbox-attachments.js' => '562bcce0',
'rsrc/js/core/behavior-line-linker.js' => 'a9b946f8',
'rsrc/js/core/behavior-more.js' => 'a80d0378',
'rsrc/js/core/behavior-object-selector.js' => '77c1f0b0',
@@ -643,7 +643,7 @@
'javelin-behavior-history-install' => '7ee2b591',
'javelin-behavior-icon-composer' => '8499b6ab',
'javelin-behavior-launch-icon-composer' => '48086888',
- 'javelin-behavior-lightbox-attachments' => 'e31fad01',
+ 'javelin-behavior-lightbox-attachments' => '562bcce0',
'javelin-behavior-line-chart' => 'e4232876',
'javelin-behavior-load-blame' => '42126667',
'javelin-behavior-maniphest-batch-selector' => 'ad54037e',
@@ -1362,6 +1362,15 @@
'javelin-vector',
'javelin-dom',
),
+ '562bcce0' => array(
+ 'javelin-behavior',
+ 'javelin-stratcom',
+ 'javelin-dom',
+ 'javelin-mask',
+ 'javelin-util',
+ 'phuix-icon-view',
+ 'phabricator-busy',
+ ),
'58dea2fa' => array(
'javelin-install',
'javelin-util',
@@ -2067,15 +2076,6 @@
'javelin-dom',
'phabricator-draggable-list',
),
- 'e31fad01' => array(
- 'javelin-behavior',
- 'javelin-stratcom',
- 'javelin-dom',
- 'javelin-mask',
- 'javelin-util',
- 'phuix-icon-view',
- 'phabricator-busy',
- ),
'e379b58e' => array(
'javelin-behavior',
'javelin-stratcom',
diff --git a/webroot/rsrc/js/core/behavior-lightbox-attachments.js b/webroot/rsrc/js/core/behavior-lightbox-attachments.js
--- a/webroot/rsrc/js/core/behavior-lightbox-attachments.js
+++ b/webroot/rsrc/js/core/behavior-lightbox-attachments.js
@@ -48,8 +48,9 @@
}
// If you click the "Download" link inside an embedded file element,
- // don't lightbox the file.
- if (e.getNode('tag:a')) {
+ // don't lightbox the file. But do lightbox when the user clicks an
+ // "<img />" inside an "<a />".
+ if (e.getNode('tag:a') && !e.getNode('tag:img')) {
return;
}

File Metadata

Mime Type
text/plain
Expires
Fri, Mar 14, 3:11 AM (2 w, 19 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7577343
Default Alt Text
D19188.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility