Differential D19180

Add "All" and "With Non-Owner Author" options for all Owners Package autoreview rules
ClosedPublic
Actions

Authored by epriestley on Mar 7 2018, 2:59 AM.

Tags

None

Referenced Files

	F15088654: D19180.id45942.diff
	Mon, Feb 17, 6:46 AM

	Unknown Object (File)
	Sun, Feb 9, 5:37 AM

	Unknown Object (File)
	Sun, Feb 9, 5:37 AM

	Unknown Object (File)
	Sun, Feb 9, 5:37 AM

	Unknown Object (File)
	Sun, Feb 9, 5:37 AM

	Unknown Object (File)
	Wed, Jan 29, 12:20 PM

	Unknown Object (File)
	Tue, Jan 28, 10:33 PM

	Unknown Object (File)
	Mon, Jan 27, 12:12 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T11664: Add option to allow owner packages to be added as reviewers to diffs, when the diff author is in the owner package
T13099: Plans: 2018 Week 10 Bonus Content
Commits: rPd14a0f4787b5: Add "All" and "With Non-Owner Author" options for all Owners Package autoreview…

Summary

Ref T13099. See PHI424. Fixes T11664. Several installs are interested in having these behaviors available in Owners by default and they aren't difficult to provide, it just makes the UI kind of messy. But I think there's enough general interest to justify it, now.

Test Plan

Created a package which owns "/" with a "With Non-Owner Author" review rule which I own. Created a revision, no package reviewer. Changed rule to "All", updated revision, got package reviewer.

Diff Detail

Repository

Branch

lunar1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19754
Build 26757: Run Core Tests
Build 26756: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 7 2018, 2:59 AM

Harbormaster completed remote builds in B19754: Diff 45941.Mar 7 2018, 3:00 AM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 7 2018, 3:00 AM

epriestley requested review of this revision.

Closed by commit rPd14a0f4787b5: Add "All" and "With Non-Owner Author" options for all Owners Package autoreview… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialTransactionEditor.php

55 lines

owners/

storage/

PhabricatorOwnersPackage.php

25 lines

docs/

user/

userguide/

23 lines

Diff 45941

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...

src/applications/owners/storage/PhabricatorOwnersPackage.php

Loading...

src/docs/user/userguide/owners.diviner

Loading...