Page MenuHomePhabricator

Hide "abraham landed Dxyz irresponsibly" stories from feed
ClosedPublic

Authored by epriestley on Mar 7 2018, 1:41 AM.
Tags
None
Referenced Files
F14475701: D19179.diff
Fri, Dec 27, 8:31 PM
Unknown Object (File)
Thu, Dec 26, 11:36 AM
Unknown Object (File)
Thu, Dec 12, 10:04 AM
Unknown Object (File)
Mon, Dec 9, 5:47 AM
Unknown Object (File)
Sun, Dec 8, 12:50 PM
Unknown Object (File)
Thu, Dec 5, 7:07 AM
Unknown Object (File)
Wed, Dec 4, 2:48 PM
Unknown Object (File)
Mon, Dec 2, 1:05 PM
Subscribers
None

Details

Summary

Ref T13099. Ref T12787. See PHI417. Differential has new "irresponsible" warnings in the timeline somewhat recently, but these publish feed stories that don't link to the revision or have other relevant details, so they're confusing on the balance.

These have a high strength so they render on top, but we actually just want to hide them from the feed and let "abraham closed Dxyz by committing rXzzz." be the primary story.

Modularize things more so that we can get this behavior. Also, respect shouldHideForFeed() at display time, not just publishing time.

Test Plan

Used bin/differential attach-commit on a non-accepted revision to "irresponsibly land" a revision. Verified that feed story now shows "closed by commit" instead of "closed irresponsibly".

Diff Detail

Repository
rP Phabricator
Branch
modular1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19752
Build 26754: Run Core Tests
Build 26753: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 7 2018, 1:48 AM
This revision was automatically updated to reflect the committed changes.