Page MenuHomePhabricator

Support "phriction.document.search" queries by "parentPaths" or "ancestorPaths"
ClosedPublic

Authored by epriestley on Feb 22 2018, 6:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 10, 4:35 PM
Unknown Object (File)
Fri, Jan 3, 5:47 AM
Unknown Object (File)
Wed, Dec 25, 6:38 PM
Unknown Object (File)
Dec 13 2024, 8:18 PM
Unknown Object (File)
Dec 7 2024, 3:08 PM
Unknown Object (File)
Dec 7 2024, 4:56 AM
Unknown Object (File)
Nov 28 2024, 2:04 AM
Unknown Object (File)
Nov 23 2024, 8:31 PM
Subscribers
None

Details

Summary

Ref T13090. Ref T13077. This adds parentPaths and ancestorPaths constraints to phriction.document.query. These should be a little more usable than the internal slugPrefix / depth stuff -- that's technically more powerful, but requires callers to know more slug normalization rules. We could perhaps expose minDepth / maxDepth in the future.

Test Plan

Ran valid and invalid parentPaths and ancestorPaths queries for /, aaa/, AAA/, etc. Got sensible-seeming results.

Diff Detail

Repository
rP Phabricator
Branch
phriction1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19634
Build 26582: Run Core Tests
Build 26581: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 22 2018, 8:49 PM
This revision was automatically updated to reflect the committed changes.