Paths

Table of Contentst

Differential D19120

Extract count/point data from tasks in Fact engines
ClosedPublic
Actions

Authored by epriestley on Feb 18 2018, 5:30 PM.

Details

Reviewers: None
Maniphest Tasks: T13083: Plans: Portals and Facts
Commits: rPe3a1a32444d0: Extract count/point data from tasks in Fact engines

Summary

Depends on D19119. Ref T13083. This is probably still very buggy, but I'm planning to build support tools to make debugging facts easier shortly.

This generates a large number of datapoints, at least, and can render some charts which aren't all completely broken in an obvious way.

Test Plan

Ran bin/fact analyze --all, got some charts with lines that went up and down in the web UI.

Diff Detail

Repository

rP Phabricator

Branch

facts2

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/fact/engine/PhabricatorFactManiphestTaskEngine.php:115	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 19623
Build 26566: Run Core Tests
Build 26565: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 18 2018, 5:30 PM

Herald added a subscriber: yelirekim. · View Herald TranscriptFeb 18 2018, 5:30 PM

Harbormaster completed remote builds in B19623: Diff 45815.Feb 18 2018, 5:31 PM

epriestley requested review of this revision.Feb 18 2018, 5:31 PM

epriestley added a child revision: D19121: Provide a page for examining the facts an object generates.Feb 19 2018, 5:43 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 19 2018, 8:06 PM

Closed by commit rPe3a1a32444d0: Extract count/point data from tasks in Fact engines (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

fact/

controller/

PhabricatorFactChartController.php

3 lines

daemon/

PhabricatorFactDaemon.php

19 lines

engine/

PhabricatorFactEngine.php

4 lines

PhabricatorFactManiphestTaskEngine.php

388 lines

fact/

PhabricatorCountFact.php

9 lines

storage/

PhabricatorFactDimension.php

10 lines

transactions/

storage/

PhabricatorApplicationTransaction.php

5 lines

Diff 45815

View Options

src/__phutil_library_map__.php

View Options

src/applications/fact/controller/PhabricatorFactChartController.php

View Options

src/applications/fact/daemon/PhabricatorFactDaemon.php

View Options

src/applications/fact/engine/PhabricatorFactEngine.php

View Options

src/applications/fact/engine/PhabricatorFactManiphestTaskEngine.php

View Options

src/applications/fact/fact/PhabricatorCountFact.php

View Options

src/applications/fact/storage/PhabricatorFactDimension.php

View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Extract count/point data from tasks in Fact enginesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45815

src/__phutil_library_map__.php

src/applications/fact/controller/PhabricatorFactChartController.php

src/applications/fact/daemon/PhabricatorFactDaemon.php

src/applications/fact/engine/PhabricatorFactEngine.php

src/applications/fact/engine/PhabricatorFactManiphestTaskEngine.php

src/applications/fact/fact/PhabricatorCountFact.php

src/applications/fact/storage/PhabricatorFactDimension.php

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Extract count/point data from tasks in Fact engines
ClosedPublic
Actions

Revision Contents
Changeset List