Page MenuHomePhabricator

Remove autodetection for whether links need "noreferrer"
ClosedPublic

Authored by epriestley on Feb 18 2018, 1:09 AM.
Tags
None
Referenced Files
F19947310: D19117.diff
Fri, Apr 17, 5:46 AM
F19925667: D19117.id45809.diff
Tue, Apr 7, 12:20 PM
F19913803: D19117.id45811.diff
Fri, Apr 3, 5:48 AM
F19829216: D19117.diff
Mar 10 2026, 2:30 AM
F19828055: D19117.diff
Mar 9 2026, 3:55 PM
F19804007: D19117.diff
Mar 2 2026, 4:14 AM
F19251206: D19117.id45809.diff
Dec 22 2025, 8:28 AM
F18869666: D19117.id.diff
Nov 4 2025, 12:54 PM
Subscribers
None

Details

Summary

Via HackerOne. See https://hackerone.com/reports/317243.

We're still detecting these wrong because browsers treat <a href=" /<newline><tab>\evil.com">click here</a> as a valid protocol-relative link to evil.com.

Just give up and add "noreferrer" at the application level at all callsites, like we do with target="_blank" already.

Test Plan

Added failing tests; ran unit tests. See also next change.

Diff Detail

Repository
rPHU libphutil
Branch
noreferrer
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19617
Build 26556: Run Core Tests
Build 26555: arc lint + arc unit