Page MenuHomePhabricator

Remove autodetection for whether links need "noreferrer"
ClosedPublic

Authored by epriestley on Feb 18 2018, 1:09 AM.
Tags
None
Referenced Files
F19251206: D19117.id45809.diff
Mon, Dec 22, 8:28 AM
F18869666: D19117.id.diff
Nov 4 2025, 12:54 PM
F18855118: D19117.diff
Nov 1 2025, 3:23 AM
F18851578: D19117.id45811.diff
Oct 31 2025, 2:19 AM
F18833147: D19117.id45811.diff
Oct 26 2025, 12:59 AM
F18772763: D19117.diff
Oct 9 2025, 4:33 AM
F18666515: D19117.id45809.diff
Sep 24 2025, 7:47 AM
F18606749: D19117.id45811.diff
Sep 13 2025, 10:33 PM
Subscribers
None

Details

Summary

Via HackerOne. See https://hackerone.com/reports/317243.

We're still detecting these wrong because browsers treat <a href=" /<newline><tab>\evil.com">click here</a> as a valid protocol-relative link to evil.com.

Just give up and add "noreferrer" at the application level at all callsites, like we do with target="_blank" already.

Test Plan

Added failing tests; ran unit tests. See also next change.

Diff Detail

Repository
rPHU libphutil
Branch
noreferrer
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19617
Build 26556: Run Core Tests
Build 26555: arc lint + arc unit