Page MenuHomePhabricator
Differential D19114

Fix incorrect context extraction for relative Phriction links on Phriction pages
ClosedPublic
Actions

Authored by epriestley on Feb 16 2018, 8:32 PM.
Tags
None
Referenced Files
F19160155: D19114.id45804.diff
Dec 15 2025, 8:20 AM
F18909886: D19114.id45803.diff
Nov 9 2025, 2:36 AM
F18836884: D19114.id45804.diff
Oct 27 2025, 3:46 AM
F18836882: D19114.id45803.diff
Oct 27 2025, 3:46 AM
F18836881: D19114.id.diff
Oct 27 2025, 3:46 AM
F18834100: D19114.diff
Oct 26 2025, 6:53 AM
F18811776: D19114.diff
Oct 20 2025, 4:54 AM
F18763763: D19114.id.diff
Oct 7 2025, 2:06 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13077: Plans: Phriction modern "v3" APIs, Drafts
Commits
rP66a7ca49b20c: Fix incorrect context extraction for relative Phriction links on Phriction pages
Summary

Ref T13077. This content extraction rule wasn't right and caused rendering on Phriction pages to extract context improperly.

Test Plan

Viewed pages in Phriction with relative links to other documents.

Diff Detail

Repository
rP Phabricator
Branch
phriction13
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19607
Build 26543: Run Core Tests
Build 26542: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 16 2018, 8:32 PM
Harbormaster completed remote builds in B19607: Diff 45803.Feb 16 2018, 8:33 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 16 2018, 8:33 PM
epriestley requested review of this revision.
Closed by commit rP66a7ca49b20c: Fix incorrect context extraction for relative Phriction links on Phriction pages (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
phriction/
markup/
2 lines

Diff 45803

View Options

src/applications/phriction/markup/PhrictionRemarkupRule.php

Loading...
Phabricator · Built by Phacility