Paths

Table of Contentst

Differential D19067

Allow "arc diff --plan-changes" to work with drafts enabled
ClosedPublic
Actions

Authored by epriestley on Feb 12 2018, 9:04 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Feb 9, 5:22 AM

	Unknown Object (File)
	Sun, Feb 9, 5:22 AM

	Unknown Object (File)
	Sun, Feb 9, 5:22 AM

	Unknown Object (File)
	Sun, Feb 9, 5:22 AM

	Unknown Object (File)
	Tue, Feb 4, 12:02 PM

	Unknown Object (File)
	Tue, Feb 4, 2:03 AM

	Unknown Object (File)
	Tue, Jan 28, 8:08 PM

	Unknown Object (File)
	Tue, Jan 28, 3:20 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction
Commits: rP11c999413493: Allow "arc diff --plan-changes" to work with drafts enabled

Summary

See PHI346. Ref T13054. If you have prototypes enabled on the server but use master / stable on the client and run arc diff --plan-changes, the transition is rejected because "Draft -> Changes Planned" isn't currently a legal transition.

Allow this transition if not coming from the web UI (to keep it out of the dropdown).

Test Plan

Ran arc diff --plan-changes on master, got a "Changes Planned" revision instead of a validation error.
Ran arc diff without --plan-changes, got a draft, verified that "Plan Changes" still doesn't appear in the action dropdown.

Diff Detail

Repository

Branch

plan1

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/differential/xaction/DifferentialRevisionPlanChangesTransaction.php:65	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 19511
Build 26399: Run Core Tests
Build 26398: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 12 2018, 9:04 PM

Harbormaster completed remote builds in B19511: Diff 45708.Feb 12 2018, 9:05 PM

epriestley requested review of this revision.Feb 12 2018, 9:05 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 12 2018, 9:15 PM

Closed by commit rP11c999413493: Allow "arc diff --plan-changes" to work with drafts enabled (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

xaction/

DifferentialRevisionPlanChangesTransaction.php

15 lines

Diff 45708

src/applications/differential/xaction/DifferentialRevisionPlanChangesTransaction.php

Loading...