Page MenuHomePhabricator
Differential D19059

Read lock all transaction edits
ClosedPublic
Actions

Authored by epriestley on Feb 11 2018, 2:05 AM.
Tags
None
Referenced Files
F14871214: D19059.id45692.diff
Sat, Feb 8, 3:52 AM
Unknown Object (File)
Fri, Feb 7, 11:25 AM
Unknown Object (File)
Thu, Jan 30, 2:58 AM
Unknown Object (File)
Wed, Jan 29, 8:46 AM
Unknown Object (File)
Tue, Jan 28, 3:19 AM
Unknown Object (File)
Mon, Jan 27, 3:22 AM
Unknown Object (File)
Fri, Jan 24, 11:57 PM
Unknown Object (File)
Fri, Jan 24, 11:57 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T12714: `differential.createcomment` can race automatic revision closure
T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction
Commits
rP653bc0fa019f: Read lock all transaction edits
Summary

Ref T13054. Fixes T12714. Applies read locks to all transactions instead of only a very select subset (chat messages in Conpherence).

Test Plan

See <T13054#235650> for discussion and testing.

Diff Detail

Repository
rP Phabricator
Branch
race1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:955XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 19495
Build 26375: Run Core Tests
Build 26374: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 11 2018, 2:05 AM
Harbormaster failed remote builds in B19494: Diff 45691!Feb 11 2018, 2:06 AM
epriestley mentioned this in T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction.Feb 11 2018, 4:00 AM
epriestley updated this revision to Diff 45692.Feb 11 2018, 4:02 AM
  • Save password hashes after upgrade (see T13054#235670).
  • Unlock and kill transactions more consistently.
Harbormaster completed remote builds in B19495: Diff 45692.Feb 11 2018, 4:02 AM
Harbormaster completed remote builds in B19495: Diff 45692.
epriestley requested review of this revision.Feb 11 2018, 4:03 AM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 11 2018, 4:07 AM
Closed by commit rP653bc0fa019f: Read lock all transaction edits (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
auth/
engine/
4 lines
conpherence/
editor/
18 lines
transactions/
editor/
162 lines

Diff 45692

View Options

src/applications/auth/engine/PhabricatorAuthPasswordEngine.php

Loading...
View Options

src/applications/conpherence/editor/ConpherenceEditor.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility