Read lock all transaction edits
ClosedPublic
Actions

Authored by epriestley on Feb 11 2018, 2:05 AM.

Details

Reviewers: None
Maniphest Tasks: T12714: `differential.createcomment` can race automatic revision closure
T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction
Commits: rP653bc0fa019f: Read lock all transaction edits

Summary

Ref T13054. Fixes T12714. Applies read locks to all transactions instead of only a very select subset (chat messages in Conpherence).

Test Plan

See <T13054#235650> for discussion and testing.

Repository

rP Phabricator

Branch

race1

Lint

Lint Passed

Unit

Tests Passed

Build Status

	Time	Test
	284 ms	PhabricatorAuthPasswordTestCase::Unknown Unit Message ("") Assertion failed, expected values to be equal (at PhabricatorAuthPasswordTestCase.php:160). Expected: 'bcrypt' Actual: 'md5'
	442 ms	PhabricatorProjectCoreTestCase::Unknown Unit Message ("") EXCEPTION (Exception): Process exited with an open transaction! The transaction will be implicitly rolled back. Calls to openTransaction() must always be paired with a call to saveTransaction() or killTransaction(). #0 /core/data/drydock/workingcopy-91/repo/phabricator/src/infrastructure/storage/lisk/LiskDAO.php(1615): AphrontDatabaseTransactionState->__destruct() #1 /core/data/drydock/workingcopy-91/repo/phabricator/src/infrastructure/storage/lisk/LiskDAO.php(1615): LiskDAO::closeAllConnections()
	1 ms	AlmanacNamesTestCase::Unknown Unit Message ("") 30 assertions passed.
	0 ms	AlmanacServiceTypeTestCase::Unknown Unit Message ("") 1 assertion passed.
	0 ms	AphrontHTTPSinkTestCase::Unknown Unit Message ("") 4 assertions passed.
		View Full Test Results (2 Failed · 357 Passed)