Paths

Table of Contentst

Differential D19047

Allow "transaction.search" to be constrained by PHIDs
ClosedPublic
Actions

Authored by epriestley on Feb 9 2018, 7:47 PM.

Tags

None

Referenced Files

	F15488106: D19047.id45671.diff
	Thu, Apr 10, 7:33 PM

	F15482590: D19047.id45664.diff
	Wed, Apr 9, 6:27 AM

	F15480321: D19047.id.diff
	Tue, Apr 8, 1:19 PM

	F15476087: D19047.diff
	Mon, Apr 7, 3:40 AM

	F15417711: D19047.id45671.diff
	Thu, Mar 20, 5:55 PM

	F15413357: D19047.id45664.diff
	Wed, Mar 19, 6:14 PM

	F15413055: D19047.id.diff
	Wed, Mar 19, 4:44 PM

	F15393645: D19047.diff
	Sat, Mar 15, 10:57 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T11330: Allow Herald to "Queue Call to Webhook: ..."
Commits: rP4887c6aa803d: Allow "transaction.search" to be constrained by PHIDs

Summary

Depends on D19046. Ref T11330. Supports querying for specific transactions while responding to webhooks.

Test Plan

Called transaction.search with and without PHID constraints.

Diff Detail

Repository

rP Phabricator

Branch

hook3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19461
Build 26327: Run Core Tests
Build 26326: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 9 2018, 7:47 PM

Harbormaster completed remote builds in B19461: Diff 45664.Feb 9 2018, 7:48 PM

epriestley requested review of this revision.Feb 9 2018, 7:48 PM

epriestley added a child revision: D19048: Trigger all "Firehose" webhooks on all transactional edits.Feb 9 2018, 8:09 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 9 2018, 9:56 PM

Closed by commit rP4887c6aa803d: Allow "transaction.search" to be constrained by PHIDs (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

aklapper mentioned this in T13255: transaction.search should accept user PHIDs as constraints.Feb 23 2019, 5:14 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

conduit/

TransactionSearchConduitAPIMethod.php

20 lines

Diff 45664

View Options

src/applications/transactions/conduit/TransactionSearchConduitAPIMethod.php

Allow "transaction.search" to be constrained by PHIDsClosedPublicActions