Page MenuHomePhabricator

Remove completely pointless load of every repository when viewing a repository URI
ClosedPublic

Authored by epriestley on Feb 8 2018, 8:43 PM.
Tags
None
Referenced Files
F15472579: D19036.id45643.diff
Sat, Apr 5, 2:49 PM
F15471498: D19036.id45643.diff
Sat, Apr 5, 5:22 AM
F15443814: D19036.id45643.diff
Thu, Mar 27, 6:18 AM
F15440858: D19036.diff
Wed, Mar 26, 3:03 PM
F15420441: D19036.id45643.diff
Fri, Mar 21, 2:03 PM
F15396036: D19036.id45643.diff
Sun, Mar 16, 11:22 AM
F15394174: D19036.id.diff
Sat, Mar 15, 11:21 PM
F15394170: D19036.diff
Sat, Mar 15, 11:21 PM
Subscribers

Details

Summary

See D18176. This query has no effect (other than wasting resources) and the result is unused.

$repository already has the URI loaded because we load them unconditionally during request initialization.

Test Plan

Viewed repository URIs.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable